Reduce allocations in some Array.Parallel funcs
#17505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Contributor
Author
|
Hmm, a3a50c0 reduces allocations significantly, but while it is faster in many scenarios, it is slower in others, depending on the size of the array and the predicate. I may take that change out, unless we know which scenarios we'd prefer to optimize for. |
brianrourkeboll
force-pushed
the
array-parallel-tweaks
branch
from
5e682c8 to
c8e6b2e
Compare
Contributor
Author
Removed that for now. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
vzarytovskii
approved these changes
Aug 9, 2024
KevinRansom
suggested changes
Aug 9, 2024
Contributor
KevinRansom
left a comment
KevinRansom
left a comment
There was a problem hiding this comment.
Looks good, however it needs the release notes updated.
vzarytovskii
added
the
NO_RELEASE_NOTES
This was referenced Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup to #14827.
'T optionallocations inArray.Parallel.tryFindIndex,Array.Parallel.tryFind, andArray.Parallel.tryPick.Checklist